Fix incremental compilation by using separate target dir for front #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just as a passing question, shouldn't this just have been a new cargo profile instead of a new cargo target directory? |
The cargo bug linked says that a new target dir is required, beyond that I cannot say. I think it's a bit easier to have cargo-leptos create a new dir than it is to create and apply a new profile |
g2p
added a commit
to g2p/cargo-leptos
that referenced
this pull request
Feb 8, 2024
The change in leptos-rs#216 was not actionable and contradicted the way the option was documented in the README. See leptos-rs#203 and leptos-rs#217.
benwis
pushed a commit
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo leptos watchcompiles frontend and server code completely new, without using incremental compilation.This is a bug of
cargoorrustc, because changing the target fromnativetowasm32changes theRUSTFLAGSwhich in turn triggers a complete rebuild by cargo (see rust-lang/cargo#8716).This PR introduces a new option in the project settings (
separate-front-target-dir) that instructscargo leptosto change the--target-dirfor the frontend compilation to<project-taget-dir>/frontso that theRUSTFLAGSstay the same between the compilations.